Repository navigation
Make the plugin compatible with GLPI 11 and 12 - #72
Open
andrefelipeufcg wants to merge 1 commit into
Open
andrefelipeufcg wants to merge 1 commit into
andrefelipeufcg wants to merge 1 commit into
Conversation
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #59
GLPI 11 and 12 compatibility
This PR only makes the plugin run on both GLPI 11 and GLPI 12 (bumped to 1.4.1). It contains no translation files; those are in a separate PR (pt_BR translation).
Changes
setup.php: version1.4.1, minimum GLPI11.0.0, maximum12.0.99.advancedforms.xml: add a 1.4.1 entry with compatibility>=11.0.0; the 1.4.0 entry is unchanged.TicketReservationRequest: remove the redeclared static properties ($itemtype,$items_id,$rightname) and set the inherited ones during plugin init. These are untyped in GLPI 11 and typed in GLPI 12, so redeclaring them with either form is a fatal error on the other version.getDefaultValueItemId()/items_id(GLPI 11) andgetDefaultValuesItemIds()/items_ids(GLPI 12).config_form.html.twig: render the_glpi_csrf_tokenfield only on GLPI 11; GLPI 12 no longer uses CSRF tokens.reservation_question.html.twig,ReservationQuestionWidget.js): on GLPI 11 use the core FullCalendar v5 with its stylesheet; on GLPI 12 load the bundled FullCalendar v6.Validation